Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: telemetry pii settings path #3665

Merged
merged 1 commit into from
May 10, 2021
Merged

port: telemetry pii settings path #3665

merged 1 commit into from
May 10, 2021

Conversation

joshgummersall
Copy link
Contributor

Fixes #3663

@joshgummersall joshgummersall requested review from a team as code owners May 10, 2021 16:54
@joshgummersall joshgummersall requested review from chrimc62 and tomlm May 10, 2021 16:54
@joshgummersall joshgummersall force-pushed the jpg/port-telemetry-logpii-path branch from f70bb13 to a76e5c2 Compare May 10, 2021 17:13
@coveralls
Copy link

coveralls commented May 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 828867654

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 85.441%
Totals Coverage Status
Change from base Build 828829124: 0.002%
Covered Lines: 19217
Relevant Lines: 21394
💛 - Coveralls

@joshgummersall joshgummersall merged commit 5499c98 into main May 10, 2021
@joshgummersall joshgummersall deleted the jpg/port-telemetry-logpii-path branch May 10, 2021 17:31
joshgummersall added a commit that referenced this pull request May 10, 2021
@joshgummersall
port: telemetry pii settings path (#3665)
3d2cf5a 
Fixes #3663
stevengum added a commit that referenced this pull request May 10, 2021
@joshgummersall @Danieladu @stevengum
cherrypick: 4.13.2 patch changes (#3667)
68bb7a6 
* fix: conflict -> precondition failed (#3645)

Fixes #3644

* Support timestamp without timezone postfix in getTimeOfDay (#3639)

* fix: add @types/express (#3652)

Co-authored-by: Steven Gum <[email protected]>

* fix: config file overrides (#3660)

Fixes #3659

* fix: add msbot keywords to component packages (#3657)

Fixes #3656

* port: telemetry pii settings path (#3665)

Fixes #3663

Co-authored-by: Hongyang Du (hond) <[email protected]>
Co-authored-by: Steven Gum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrichardson mdrichardson mdrichardson approved these changes

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Update telemetry LogPersonalInformation config path for recognizers (#5568)
3 participants
@joshgummersall @coveralls @mdrichardson