Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add @types/express #3652

Merged
merged 2 commits into from
May 6, 2021
Merged

fix: add @types/express #3652

merged 2 commits into from
May 6, 2021

Conversation

joshgummersall
Copy link
Contributor

In testing and customizing a bot using the express integration, I noticed that app was typed as any:

Screen Shot 2021-05-05 at 10 24 56 AM

#minor

@joshgummersall joshgummersall requested a review from stevengum May 5, 2021 17:25
@joshgummersall joshgummersall force-pushed the jpg/fix-express-types branch from f96752d to 03bca56 Compare May 5, 2021 18:00
@coveralls
Copy link

coveralls commented May 5, 2021

Pull Request Test Coverage Report for Build 818019810

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.434%

Totals Coverage Status
Change from base Build 817702649: 0.2%
Covered Lines: 19225
Relevant Lines: 21402

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@stevengum stevengum merged commit af9a8b3 into main May 6, 2021
@stevengum stevengum deleted the jpg/fix-express-types branch May 6, 2021 21:07
joshgummersall added a commit that referenced this pull request May 10, 2021
stevengum added a commit that referenced this pull request May 10, 2021
* fix: conflict -> precondition failed (#3645)

Fixes #3644

* Support timestamp without timezone postfix in getTimeOfDay (#3639)

* fix: add @types/express (#3652)

Co-authored-by: Steven Gum <[email protected]>

* fix: config file overrides (#3660)

Fixes #3659

* fix: add msbot keywords to component packages (#3657)

Fixes #3656

* port: telemetry pii settings path (#3665)

Fixes #3663

Co-authored-by: Hongyang Du (hond) <[email protected]>
Co-authored-by: Steven Gum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants