Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove var, add lint rule #3179

Merged
merged 2 commits into from
Jan 8, 2021
Merged

fix: remove var, add lint rule #3179

merged 2 commits into from
Jan 8, 2021

Conversation

joshgummersall
Copy link
Contributor

Add no-var eslint rule, fix var usage (and prettier formatting).

@joshgummersall joshgummersall requested a review from a team as a code owner January 8, 2021 22:55
@joshgummersall
Copy link
Contributor Author

Note: fixes due to my accidental early merge of #3175

@joshgummersall joshgummersall mentioned this pull request Jan 8, 2021
Merged
@v-kydela
Copy link
Contributor

v-kydela commented Jan 8, 2021

Please do not merge this until I patch it

@v-kydela
Copy link
Contributor

v-kydela commented Jan 8, 2021

Okay done

@coveralls
Copy link

coveralls commented Jan 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 473022212

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.01%) to 84.358%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-azure/src/cosmosDbPartitionedStorage.ts 1 77.07%
libraries/adaptive-expressions/src/triggerTrees/node.ts 2 95.26%
Totals Coverage Status
Change from base Build 472995275: -0.01%
Covered Lines: 17742
Relevant Lines: 20090
💛 - Coveralls

@joshgummersall joshgummersall merged commit 6e2b89f into main Jan 8, 2021
@joshgummersall joshgummersall deleted the jpg/fix-var branch January 8, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshgummersall @v-kydela @coveralls