-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cosmos nesting problem #3175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 472780698
💛 - Coveralls |
joshgummersall
suggested changes
Jan 8, 2021
…om/microsoft/botbuilder-js into jpg/port-cosmos-nesting-error-info
private checkForNestingError(json: object, err: Error | Record<'message', string> | string): void { | ||
const checkDepth = (obj: unknown, depth: number, isInDialogState: boolean): void => { | ||
if (depth > maxDepthAllowed) { | ||
var message: string = `Maximum nesting depth of ${maxDepthAllowed} exceeded.`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let
preferred to var
.
joshgummersall
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3126
Description
Some customers experienced cryptic error messages when using Cosmos. We discovered that deeply nested data was the culprit, so I've added new error messages to help customers who encounter this problem in the future.
Specific Changes
Testing
Included. Note that waterfall dialogs break recorded tests by generating random instance ID's, and mockHelper.js is designed to fix the test data by looking for waterfall dialogs in the root dialog stack. It is not designed to look for waterfall dialogs inside component dialogs, so it cannot automatically fix the recorded test data for the dialog nesting test. Rather than fixing mockHelper.js or trying some type of non-waterfall dialog, I decided to edit the test data manually because I am told we will be moving to a new testing system soon. This was the simplest solution, but it means that it will need to be manually edited again if new test data is recorded for the dialog nesting test.