Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: immediate accept" #3092

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

joshgummersall
Copy link
Contributor

Reverts #2950

@coveralls
Copy link

coveralls commented Nov 24, 2020

Pull Request Test Coverage Report for Build 381698678

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 84.814%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder/src/botFrameworkAdapter.ts 39 88.53%
Totals Coverage Status
Change from base Build 381617353: 0.02%
Covered Lines: 17346
Relevant Lines: 19529

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this feature being reverted?

@joshgummersall
Copy link
Contributor Author

@stevengum there was some impedance mismatch between what the Health Bot team wanted and what we delivered. Rather than leaving stale code in the SDK, it seems better to remove it.

Alternatively, if this still seems like something that other customers could make use of, we can just revert it from the 4.11 branch.

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshgummersall we should also revert it in 4.11 so that it isn’t accidentally shipped it in a patch release.

If we don’t want to lose the code, we could either put it on a branch and/or place it in a tracking issue; the benefit of the issue is that we’re less likely to lose track of it in future milestones...

Alternatively, there is the BotBuilder-samples/experimental route

@stevengum
Copy link
Member

Since there is nothing pressing on this implementation being shipped, we’ll have more bake time for the requested feature.

@joshgummersall joshgummersall merged commit 6f1c8e7 into main Nov 24, 2020
@joshgummersall joshgummersall deleted the revert-2950-jpg/immediate-accept branch November 24, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants