feat: immediate accept #2950
Merged
feat: immediate accept #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
carlosscastro,
johnataylor,
stevengum and
Stevenic
as code owners
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
4baf554 to
7945d19
Compare
joshgummersall
changed the base branch from
main
to
jpg/refactor-middleware-set
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
7945d19 to
aeb308d
Compare
joshgummersall
force-pushed
the
jpg/refactor-middleware-set
branch
from
edbdade to
f93e8bc
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
aeb308d to
b32f1f9
Compare
joshgummersall
force-pushed
the
jpg/refactor-middleware-set
branch
from
f93e8bc to
ba38eba
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
b32f1f9 to
13f01eb
Compare
joshgummersall
force-pushed
the
jpg/refactor-middleware-set
branch
from
ba38eba to
64c5334
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
2 times, most recently
from
eb7641b to
9404190
Compare
joshgummersall
force-pushed
the
jpg/refactor-middleware-set
branch
from
390b0bd to
20f0f39
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
9404190 to
8d9c67c
Compare
joshgummersall
force-pushed
the
jpg/refactor-middleware-set
branch
from
20f0f39 to
543336d
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
8d9c67c to
39b5872
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
2 times, most recently
from
8d06478 to
f878774
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
2 times, most recently
from
ba96b0f to
6f16786
Compare
|
please notify @scheyal when ready to share bits with customers. Thank you :) |
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
73af8a8 to
637ac5e
Compare
joshgummersall
force-pushed
the
jpg/immediate-accept
branch
from
637ac5e to
f77edc7
Compare
johnataylor
approved these changes
Nov 17, 2020
Pull Request Test Coverage Report for Build 367159326
💛 - Coveralls |
joshgummersall
added a commit
that referenced
this pull request
Nov 17, 2020
* Add support for `immediateAccept` option Fixes microsoft/botframework-sdk#6005 * strict boolean coercion
joshgummersall
added a commit
that referenced
this pull request
Nov 18, 2020
* Add support for `immediateAccept` option Fixes microsoft/botframework-sdk#6005 * strict boolean coercion
joshgummersall
added a commit
that referenced
this pull request
Nov 24, 2020
joshgummersall
added a commit
that referenced
this pull request
Nov 24, 2020
This reverts commit cdfa484.
joshgummersall
added a commit
that referenced
this pull request
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/botframework-sdk#6005
This PR introduces a new
BotFrameworkAdapteroption forimmediateAccept. This feature, while useful, is potentially dangerous as it can lead to silent errors and unpredictable behavior in shared hosting environments. That said, it may be useful for certain users that leverage middleware chains or bot logic that takes a long time to execute.The
immediateAcceptsetting can be either a simple boolean flag or a function that is passed an activity and must return a boolean value. Under certain special scenarios, this setting is entirely ignored.Note: This PR also introduces some refactoring to the code that simplifies middleware execution and better leverages newer Javascript features and Typescript type inference.