Refactored resource explorer as well as related components #2342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chon219
requested review from
boydc2014,
carlosscastro,
chrimc62,
luhan2017 and
a team
as code owners
Pull Request Test Coverage Report for Build 151793
💛 - Coveralls |
This was
linked to
issues
Jun 14, 2020
stevengum
previously requested changes
Jul 23, 2020
libraries/botbuilder-dialogs-declarative/src/resources/folderResourceProvider.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-dialogs-declarative/src/resources/fileResource.ts
Outdated
Show resolved
Hide resolved
| "codelyzer": "^4.1.0", | ||
| "mocha": "^6.2.3", | ||
| "nyc": "^15.1.0", | ||
| "source-map-support": "^0.5.3", | ||
| "ts-node": "^4.1.0" | ||
| }, | ||
| "scripts": { | ||
| "test": "tsc && nyc mocha tests/", | ||
| "test": "tsc && nyc mocha tests/ --exit", |
There was a problem hiding this comment.
Yes, we added some tests to test if resource explorer can monitor folder changes continuously, which may prevent mocha tests exiting as usual. Any better suggestions?
libraries/botbuilder-dialogs-adaptive/src/generators/languageGeneratorManager.ts
Outdated
Show resolved
Hide resolved
|
IMHO - it is fine to have an abstract base class for providing default implementation shared across derived classes. However, I don't think this has to mean removing the interfaces. By removing the interface, the other classes become dependent on a specific implementation. Interfaces do a good job of defining the contract in Typescript and get compiled away. There aren't the same tradeoffs between ABCs and interfaces like there are in .NET. |
stevengum
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1959
Description
Changed some components from interfaces to abstract class to align with dotnet sdk
Refactored resource explorer to support more resource types besides ".dialog"
Refactored event emitters to expose add/change/remove events on resources
Clean up unused code and unused dependencies in botbuilder-dialogs-declarative
Specific Changes
Resource: interface -> abstract classResourceProvider: interface -> abstract classchokidarinstead ofnode-watchto expose added/changed/removed events on resources for tracking resource changes more preciselyLanguageGeneratorManageruse resource explorer to track LG files changesFileResourceProviderTesting
Test cases added to test resource changes tracking by resource explorer.