New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Replace resource interfaces with abstract base classes #2131

Closed

tomlm opened this issue Apr 29, 2020 · 0 comments · Fixed by #2342

Assignees

Labels

R10

Milestone

Contributor

tomlm commented Apr 29, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3811

For future proofing we want to minimize interfaces and use abstract classes as approproriate

Add method to add new resourceType (and reload resources)
Properly modeled event using EventHandler

Changed projects

Microsoft.Bot.Builder.Dialogs.Adaptive
Microsoft.Bot.Builder.Dialogs.Declarative
Microsoft.Bot.Builder.Dialogs.Adaptive.Tests
Microsoft.Bot.Builder.Dialogs.Declarative.Tests
Microsoft.Bot.Builder.TestBot.Json

[Adaptive]

github-actions bot added the Adaptive label

luhan2017 added the R10 label

chon219 linked a pull request

that will close this issue

Refactored resource explorer as well as related components #2342

Merged

chon219 self-assigned this

munozemilio added this to the R10 milestone

stevengum closed this as completed in #2342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment