Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(AGAINST MASTER) Remove node exports from utilities #2228

Merged
merged 1 commit into from
May 13, 2020
Merged

(AGAINST MASTER) Remove node exports from utilities #2228

merged 1 commit into from
May 13, 2020

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented May 12, 2020

Fixes #2224

Description

Per offline discussion, Chris M. asked that we do the PR against master
See #2223 for PR against 4.9 counterpart

@Zerryth Zerryth requested review from stevengum and ckkashyap May 12, 2020 19:26
@coveralls
Copy link

coveralls commented May 12, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 130409

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 79.997%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 129555: -0.07%
Covered Lines: 12649
Relevant Lines: 15087
💛 - Coveralls

@stevengum
Copy link
Member

@ckkashyap validated this PR

@stevengum stevengum merged commit 0656bdf into master May 13, 2020
@stevengum stevengum deleted the Zerryth/remove-node-from-browser branch May 13, 2020 17:17
@stevengum stevengum mentioned this pull request May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@ckkashyap ckkashyap Awaiting requested review from ckkashyap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webpack fails with botframework-streaming due to Node.js "net" dependency
3 participants
@Zerryth @coveralls @stevengum