Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node exports from utilities #2223

Merged
merged 2 commits into from
May 27, 2020
Merged

Remove node exports from utilities #2223

merged 2 commits into from
May 27, 2020

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented May 12, 2020 •
edited
Loading

Fixes #2224

Description

loading bf-streaming in browser yields error:
image

browserWebSocket.ts imports utilities, which included createNodeServer

Removed reference to this node export in utilities

@stevengum stevengum requested review from ckkashyap and stevengum May 12, 2020 18:42
@stevengum stevengum mentioned this pull request May 12, 2020
Closed
@cleemullins
Copy link
Contributor

I'm not convinced we need to take this in 4.9. Hasn't this been here for... months?

@Zerryth Zerryth changed the base branch from 4.9 to master May 12, 2020 19:18
@Zerryth Zerryth changed the base branch from master to 4.9 May 12, 2020 19:18
@Zerryth Zerryth mentioned this pull request May 12, 2020
Merged
@compulim compulim mentioned this pull request May 13, 2020
Closed
34 tasks
@stevengum
Copy link
Member

For 4.9.1.

@stevengum stevengum added the R9 Release 9 - May 15th, 2020 label May 13, 2020
@stevengum stevengum mentioned this pull request May 13, 2020
Closed
@stevengum stevengum requested a review from compulim May 18, 2020 17:40
@cleemullins cleemullins added blocked Current progress is blocked on something else. BF:Patch:4.9 labels May 20, 2020
@coveralls
Copy link

coveralls commented May 20, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 132796

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0009%) to 80.207%
Totals Coverage Status
Change from base Build 131512: -0.0009%
Covered Lines: 12644
Relevant Lines: 15048
💛 - Coveralls

@stevengum stevengum merged commit 2a194c1 into 4.9 May 27, 2020
@stevengum stevengum deleted the Zerryth/remove-node-refs-in-browser branch May 27, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@ckkashyap ckkashyap Awaiting requested review from ckkashyap

@compulim compulim Awaiting requested review from compulim

Assignees
No one assigned
Labels
blocked Current progress is blocked on something else. R9 Release 9 - May 15th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zerryth @cleemullins @stevengum @coveralls