Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LG] Remove dash in identifier to make sure arithmetic expressions can be parsed correctly #2009

Merged
merged 3 commits into from
Apr 10, 2020
Merged

[LG] Remove dash in identifier to make sure arithmetic expressions can be parsed correctly #2009

merged 3 commits into from
Apr 10, 2020

Conversation

cosmicshuai
Copy link
Contributor

@cosmicshuai cosmicshuai commented Apr 10, 2020 •
edited
Loading

fixes: #2011

In this PR, identifier can not contain '-'. Template name should not use 'bfactivity-1123'.
This change will make sure expressions like 'user.a-user.b' can be recognize as an arithmetic opration rather than an identifier.

@coveralls
Copy link

coveralls commented Apr 10, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 119030

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 66.942%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 118870: -0.08%
Covered Lines: 10236
Relevant Lines: 14466
💛 - Coveralls

@cosmicshuai cosmicshuai merged commit 0b24fa6 into master Apr 10, 2020
@cosmicshuai cosmicshuai deleted the shuwan/fixDashInIden branch April 10, 2020 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danieladu Danieladu Danieladu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PORT] [LG] Remove dash in identifier to make sure arithmetic expressions can be parsed correctly
3 participants
@cosmicshuai @coveralls @Danieladu