Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT] [LG] Remove dash in identifier to make sure arithmetic expressions can be parsed correctly #2011

Closed
tomlm opened this issue Apr 10, 2020 · 0 comments · Fixed by #2009

Comments

@tomlm
Copy link
Contributor

tomlm commented Apr 10, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3712

fixes: #3695
In this PR, identifier can not contain '-'. Template name should not use 'bfactivity-1123'.
This change will make sure expressions like 'user.a-user.b' can be recognize as an arithmetic opration rather than an identifier.

Changed projects

  • AdaptiveExpressions
  • Microsoft.Bot.Builder.LanguageGeneration
  • AdaptiveExpressions.Tests
  • Microsoft.Bot.Builder.Dialogs.Adaptive.Templates.Tests
  • Microsoft.Bot.Builder.Dialogs.Adaptive.Tests
  • Microsoft.Bot.Builder.LanguageGeneration.Tests
  • Microsoft.Bot.Builder.TestBot.Json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants