Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PORT]Loose grammar to make Structure LG more torren #1976

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Conversation

Danieladu
Copy link
Contributor

Close: #1973

  1. Support newline in structure lg content
> this is executable
# template
[Activity
  text = hi

 speak = hi
]
  1. Add more catchable errors
    for example:
# template
[Activity]
- hi

Originally, it would throw a syntax error, but now, some readable errors would be thrown.

@Danieladu Danieladu requested a review from cosmicshuai April 2, 2020 05:11
@coveralls
Copy link

coveralls commented Apr 2, 2020

Pull Request Test Coverage Report for Build 117121

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 81.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/adaptive-expressions/src/parser/expressionParser.ts 1 2 50.0%
Totals Coverage Status
Change from base Build 117115: 0.02%
Covered Lines: 9341
Relevant Lines: 11042

💛 - Coveralls

@cosmicshuai cosmicshuai merged commit 9d768ed into master Apr 2, 2020
@cosmicshuai cosmicshuai deleted the hond/fix branch April 2, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PORT] [LG] Loose grammar to make Structure LG more torrent
3 participants