Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] [LG] Loose grammar to make Structure LG more torrent #1973

Closed
tomlm opened this issue Apr 2, 2020 · 0 comments · Fixed by #1976
Closed

[PORT] [LG] Loose grammar to make Structure LG more torrent #1973

tomlm opened this issue Apr 2, 2020 · 0 comments · Fixed by #1976

Comments

@tomlm
Copy link
Contributor

tomlm commented Apr 2, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3654

  1. Support newline in structure lg content
> this is executable
# template
[Activity
  text = hi

 speak = hi
]
  1. Add more catchable errors
    for example:
# template
[Activity]
- hi

Originally, it would throw a syntax error, but now, some readable errors would be thrown.

Changed projects

  • Microsoft.Bot.Builder.LanguageGeneration
  • Microsoft.Bot.Builder.LanguageGeneration.Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PORT]Loose grammar to make Structure LG more torren microsoft/botbuilder-js
2 participants
@Danieladu @tomlm