Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses issue 635, relating to newlines in Windows. #678

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

afourney
Copy link
Member

Why are these changes needed?

When run_scenarios.py creates the run.sh file on Windows, lines are terminated with \r\n. Docker has trouble when trying to run such files. This PR forces unix newlines, and addresses some other Windows incompatibilities.

Related issue number

Closes #635

Checks

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (72f488e) 28.70% compared to head (5f478d6) 28.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   28.70%   28.70%           
=======================================
  Files          27       27           
  Lines        3383     3383           
  Branches      760      760           
=======================================
  Hits          971      971           
  Misses       2341     2341           
  Partials       71       71           
Flag Coverage Δ
unittests 28.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit b0a6d72 Nov 15, 2023
16 checks passed
@sonichi sonichi deleted the testbed_635 branch November 15, 2023 22:59
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj-autogenbench Issues related to AutoGenBench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples/tools/testbed/run_scenarios.py prepare the run script fails in windows environment
3 participants