Skip to content

samples/tools/testbed/run_scenarios.py prepare the run script fails in windows environment #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garyfollett opened this issue Nov 12, 2023 · 2 comments · Fixed by #678

Comments

@garyfollett
Copy link

the run.sh will fail in the docker container in a windows environment if newline='\n' is not included in the call.

with open(os.path.join(work_dir, "run.sh"), "wt", newline='\n') as f:

@afourney
Copy link
Member

Thanks for the report. I'll fix this ASAP, and include the fix in all cases where a file is written by the host OS, and read in the Docker image (I suspect that is the incompatibility here)

@afourney
Copy link
Member

@garyfollett I believe I have addressed this in PR #678

Please have a look and let us know if it works for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants