Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to specify a different requirements.txt file to install … #671

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

afourney
Copy link
Member

…in Docker, to test other versions or branches of Autogen. Closes #662

Adds a --requirements command line attribute, to specify a different requirements file to install in Docker before running scenarios. This allows you to test on different branches or versions of Autogen.

Why are these changes needed?

Previously, one needed to edit run_scenarios.py to run the testbest on anything other than the most recent stable version of Autogen in PyPI.

Related issue number

Closes #662

Checks

…in Docker, to test other versions or branches of Autogen. Closes #662
@afourney afourney added the proj-autogenbench Issues related to AutoGenBench. label Nov 13, 2023
@afourney afourney requested a review from a team November 13, 2023 23:58
@afourney afourney self-assigned this Nov 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c374537) 28.70% compared to head (a704213) 28.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #671   +/-   ##
=======================================
  Coverage   28.70%   28.70%           
=======================================
  Files          27       27           
  Lines        3383     3383           
  Branches      760      760           
=======================================
  Hits          971      971           
  Misses       2341     2341           
  Partials       71       71           
Flag Coverage Δ
unittests 28.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rickyloynd-microsoft rickyloynd-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@afourney afourney requested a review from a team November 14, 2023 21:00
@sonichi sonichi added this pull request to the merge queue Nov 14, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 14, 2023
@sonichi sonichi added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit 72f488e Nov 15, 2023
16 checks passed
@sonichi sonichi deleted the testbed_662 branch November 15, 2023 00:40
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
…in Docker, to test other versions or branches of Autogen. Closes microsoft#662 (microsoft#671)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj-autogenbench Issues related to AutoGenBench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterize the version of pyautogen that gets installed in the Testbed Docker environment
4 participants