Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the umask before executing the task in Docker. #593

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

afourney
Copy link
Member

@afourney afourney commented Nov 8, 2023

Why are these changes needed?

When code is run in Docker, the output files are owned by root, and may not be manageable by the user who is running Autogen. This PR sets the umask to 000 so that files created in the Testbed's docker environment are world-writable, and can be managed.

Related issue number

Closes #592

Checks

@afourney afourney added the proj-autogenbench Issues related to AutoGenBench. label Nov 8, 2023
@afourney afourney self-assigned this Nov 8, 2023
Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to confirm whether this is intended for use of pyautogen<0.2 only, and if so, the README needs to state that.

samples/tools/testbed/scenarios/human_eval_two_agents.py Outdated Show resolved Hide resolved
samples/tools/testbed/run_scenarios.py Show resolved Hide resolved
@afourney
Copy link
Member Author

@sonichi Please have another look. I've added version backward compatibility.

The ability to specify other Autogen versions is also in another per #671

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2a96e4d) 34.04% compared to head (095703e) 28.70%.
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
- Coverage   34.04%   28.70%   -5.35%     
==========================================
  Files          25       27       +2     
  Lines        3005     3383     +378     
  Branches      668      760      +92     
==========================================
- Hits         1023      971      -52     
- Misses       1906     2341     +435     
+ Partials       76       71       -5     
Flag Coverage Δ
unittests 28.64% <ø> (-5.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit c374537 Nov 14, 2023
16 checks passed
@sonichi sonichi deleted the testbed_umask_592 branch November 14, 2023 21:28
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* Sets the umask before executing the task in Docker.

* Added version backward compatibility for disabling cache and setting timeouts.
jackgerrits pushed a commit that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj-autogenbench Issues related to AutoGenBench.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When Testbed scenarios are run in Docker, logs and files are owned by root.
4 participants