Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for windows and improve sample code #38

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Fix bug for windows and improve sample code #38

merged 9 commits into from
Sep 28, 2023

Conversation

sonichi
Copy link
Contributor

@sonichi sonichi commented Sep 28, 2023

Why are these changes needed?

  1. Fix bug for windows
  2. Better example

Related issue number

close #17
close #19

Checks

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Merging #38 (c4a1530) into main (d3d5dca) will increase coverage by 0.19%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   35.16%   35.36%   +0.19%     
==========================================
  Files          17       17              
  Lines        1965     1971       +6     
  Branches      432      434       +2     
==========================================
+ Hits          691      697       +6     
+ Misses       1223     1222       -1     
- Partials       51       52       +1     
Flag Coverage Δ
unittests 35.26% <66.66%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
autogen/agentchat/assistant_agent.py 83.33% <ø> (ø)
autogen/version.py 100.00% <100.00%> (ø)
autogen/code_utils.py 47.03% <81.81%> (+1.49%) ⬆️

@sonichi sonichi temporarily deployed to openai September 28, 2023 18:47 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai September 28, 2023 18:47 — with GitHub Actions Inactive
@sonichi sonichi temporarily deployed to openai September 28, 2023 18:47 — with GitHub Actions Inactive
@sonichi sonichi changed the title Fix bug for windows Fix bug for windows and improve sample code Sep 28, 2023
@rickyloynd-microsoft
Copy link
Contributor

I followed the installation steps in the win branch (pip install pyautogen), then modified and renamed OAI_CONFIG_LIST_sample.json as suggested, and ran the new test (python test/twoagent.py). The first agent turn replied with code as expected. I pressed enter to use auto-reply, and got the error mentioned in issue #17 :

pywintypes.error: (2, 'CreateFile', 'The system cannot find the file specified.')

Then I did pip install docker and ran the test again. The error changed:

docker.errors.DockerException: Error while fetching server API version: (2, 'CreateFile', 'The system cannot find the file specified.')

@sonichi
Copy link
Contributor Author

sonichi commented Sep 28, 2023

I followed the installation steps in the win branch (pip install pyautogen), then modified and renamed OAI_CONFIG_LIST_sample.json as suggested, and ran the new test (python test/twoagent.py). The first agent turn replied with code as expected. I pressed enter to use auto-reply, and got the error mentioned in issue #17 :

pywintypes.error: (2, 'CreateFile', 'The system cannot find the file specified.')

Then I did pip install docker and ran the test again. The error changed:

docker.errors.DockerException: Error while fetching server API version: (2, 'CreateFile', 'The system cannot find the file specified.')

Could you use pip install -e. instead of pip install pyautogen?

@rickyloynd-microsoft
Copy link
Contributor

I followed the installation steps in the win branch (pip install pyautogen), then modified and renamed OAI_CONFIG_LIST_sample.json as suggested, and ran the new test (python test/twoagent.py). The first agent turn replied with code as expected. I pressed enter to use auto-reply, and got the error mentioned in issue #17 :
pywintypes.error: (2, 'CreateFile', 'The system cannot find the file specified.')
Then I did pip install docker and ran the test again. The error changed:
docker.errors.DockerException: Error while fetching server API version: (2, 'CreateFile', 'The system cannot find the file specified.')

Could you use pip install -e. instead of pip install pyautogen?

This worked, and after enough turns (test1.txt) it displayed the chart:

image

@sonichi sonichi enabled auto-merge September 28, 2023 20:08
@sonichi sonichi added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 402c5bf Sep 28, 2023
0 of 3 checks passed
@sonichi sonichi deleted the win branch September 28, 2023 21:33
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* fix bug for windows

* fix bug for windows

* more clear example

* link to example

* add test

* format

* comment

* fix assertion error

* fix test error and links

---------

Co-authored-by: Chi Wang (MSR) <[email protected]>
randombet pushed a commit to randombet/autogen that referenced this pull request Sep 26, 2024
jackgerrits added a commit that referenced this pull request Oct 2, 2024
* Add doc about how to use aad for model client

* update after testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gettig Error while running "autogen.UserProxyAgent" TypeError: can only concatenate str (not "bytes") to str
3 participants