Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Image Generation Notebook #2213

Merged
merged 6 commits into from
Mar 31, 2024
Merged

Improve Image Generation Notebook #2213

merged 6 commits into from
Mar 31, 2024

Conversation

WaelKarkoub
Copy link
Contributor

Why are these changes needed?

When I first made this notebook, I didn't expect it to be rendered on the website:

  • Improved title and descriptions.
  • Followed the contribution guidelines closely for consistency.
  • Removed caching (I think most users of the notebook are experimenting, so it didn't make sense to cache)
  • Fixed bugs

Related issue number

Checks

@WaelKarkoub WaelKarkoub requested a review from jackgerrits March 30, 2024 01:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.83%. Comparing base (989c182) to head (20a0428).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2213   +/-   ##
=======================================
  Coverage   37.83%   37.83%           
=======================================
  Files          77       77           
  Lines        7766     7766           
  Branches     1663     1663           
=======================================
  Hits         2938     2938           
  Misses       4579     4579           
  Partials      249      249           
Flag Coverage Δ
unittests 37.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi requested a review from BeibinLi March 31, 2024 02:48
Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Side note: if we want to render the notebook in the website, then we need to add metadata to the notebook.

See #1495

Maybe we don't need to do that right now, but @jackgerrits can give instructions in the future.

@WaelKarkoub
Copy link
Contributor Author

@BeibinLi The notebook is currently being rendered (https://microsoft.github.io/autogen/docs/notebooks/agentchat_image_generation_capability/), however, the title and the description didn't make sense in the context of the website, so I just opened this PR to improve that.

@sonichi sonichi added this pull request to the merge queue Mar 31, 2024
@sonichi sonichi requested a review from victordibia March 31, 2024 22:53
Merged via the queue into main with commit fd96d3d Mar 31, 2024
27 checks passed
@WaelKarkoub WaelKarkoub deleted the render-gen-images-notebook branch March 31, 2024 23:07
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants