-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notebooks section on website #1495
Conversation
…nsumers of the notebook
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1495 +/- ##
=======================================
Coverage 34.30% 34.30%
=======================================
Files 42 42
Lines 5110 5110
Branches 1169 1169
=======================================
Hits 1753 1753
Misses 3213 3213
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fantastic PR Jack-- it preserves the current dev flow for adding new notebooks and improves the website! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this PR. Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor issue.
* Initial infrasctructure for notebooks page * migrate two notebooks * add readme notification for notebook dir * override 'text' prism language to add basic syntactical structure to autogens output * Rework to retain existing directory and not expose front matter to consumers of the notebook * improve error handling of process notebooks * format, ruff and type fixes * undo changes to navbar * update readme, CI * whitespace * spelling mistakes * spelling * Add contributing guide for notebooks * update notebook * formatting
This PR adds support for rendering notebooks on the website. It automatically includes files from
/notebook
after they have a small amount of metadata added.Once there are a sufficient number of notebooks opted in web can enable the Notebooks section in the navbar so users can find it.
To add a notebook to the website it should include a comment at the very top containing two yaml properties:
Related issue number
#1339