Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [autogenbench] fails on win-os unless we specify encoding #1957

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: [autogenbench] fails on win-os unless we specify encoding #1957

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4553f
fix: [autogenbench] windows fails unless we specify encoding
lalo Mar 11, 2024
e11eb1e
Merge branch 'main' into patch-1
lalo Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/tools/autogenbench/autogenbench/run_cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,7 +492,7 @@ def run_scenario_in_docker(work_dir, env, timeout=TASK_TIMEOUT, docker_image=Non
docker_timeout = timeout + 60 # One full minute after the bash timeout command should have already triggered
start_time = time.time()
logs = container.logs(stream=True)
log_file = open(os.path.join(work_dir, "console_log.txt"), "wt")
log_file = open(os.path.join(work_dir, "console_log.txt"), "wt", encoding="utf-8")
stopping = False

for chunk in logs: # When streaming it should return a generator
Expand Down
Loading