Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [autogenbench] fails on win-os unless we specify encoding #1957

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix: [autogenbench] fails on win-os unless we specify encoding #1957

merged 2 commits into from
Mar 12, 2024

Conversation

lalo
Copy link
Member

@lalo lalo commented Mar 11, 2024 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

@sonichi sonichi requested a review from afourney March 11, 2024 19:25
@lalo lalo changed the title fix: [autogenbench] windows fails unless we specify encoding fix: [autogenbench] fails on winos unless we specify encoding Mar 11, 2024
@lalo lalo changed the title fix: [autogenbench] fails on winos unless we specify encoding fix: [autogenbench] fails on win-os unless we specify encoding Mar 11, 2024
@sonichi sonichi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into microsoft:main with commit a814ba5 Mar 12, 2024
20 checks passed
@lalo lalo mentioned this pull request Mar 13, 2024
Merged
3 tasks
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
@lalo
fix: [autogenbench] windows fails unless we specify encoding (microso…
2c1eaa8 
…ft#1957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackgerrits jackgerrits jackgerrits approved these changes

@afourney afourney Awaiting requested review from afourney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalo @jackgerrits @sonichi