Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type issues in math_utils.py #1544

Closed
wants to merge 1 commit into from

Conversation

jackgerrits
Copy link
Member

Why are these changes needed?

Related issue number

#1462

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b217c9) 34.24% compared to head (5b88ccc) 40.43%.

Files Patch % Lines
autogen/math_utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1544      +/-   ##
==========================================
+ Coverage   34.24%   40.43%   +6.18%     
==========================================
  Files          42       42              
  Lines        5098     5105       +7     
  Branches     1165     1234      +69     
==========================================
+ Hits         1746     2064     +318     
+ Misses       3209     2852     -357     
- Partials      143      189      +46     
Flag Coverage Δ
unittests 40.41% <92.85%> (+6.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is currently not covered by test. It was covered by a test for a functionality only supported using the old openai completion api. We haven't migrated that functionality to v0.2. We might either migrate it or remove it. So, please avoid making changes in these files before that decision is made.

@jackgerrits
Copy link
Member Author

In that case should we ignore type checking in this file? If so, I will add it to the exclusions list in #1543 and close this

@jackgerrits jackgerrits closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants