Add mypy config to pyproject.toml #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1543 +/- ##
===========================================
+ Coverage 35.19% 46.99% +11.80%
===========================================
Files 44 44
Lines 5328 5328
Branches 1236 1305 +69
===========================================
+ Hits 1875 2504 +629
+ Misses 3299 2613 -686
- Partials 154 211 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
ekzhu
approved these changes
Feb 7, 2024
|
This is great! All new files in my past PRs conform to this already and I found a few bugs already because of mypy errors. |
|
Music to my ears! |
whiskyboy
pushed a commit
to whiskyboy/autogen
that referenced
this pull request
Apr 17, 2024
* Add mypy config to pyproject.toml * put back follow_imports * ignore math utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
@davorrunje @ekzhu I am merging just the mypy config that I have seen in some of your PRs. As I am sure you're aware, we're very far away from being able to enforce this in CI. But at the very least having the config merged allows us to make progress towards this.
Related issue number
#1462
Checks