Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permission block for deploy-website.yml #1397

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

ekzhu
Copy link
Collaborator

@ekzhu ekzhu commented Jan 25, 2024

Based on the instruction here: https://github.com/peaceiris/actions-gh-pages?tab=readme-ov-file#%EF%B8%8F-first-deployment-with-github_token

Write permission is needed to publish GitHub page content to the gh-pages branch.

Why are these changes needed?

Org-wide policy change. Now permissions block is required.

Related issue number

#1264

Checks

@ekzhu ekzhu requested a review from sonichi January 25, 2024 06:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcfd770) 32.48% compared to head (559b5c0) 32.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   32.48%   32.48%           
=======================================
  Files          41       41           
  Lines        4907     4907           
  Branches     1120     1120           
=======================================
  Hits         1594     1594           
  Misses       3187     3187           
  Partials      126      126           
Flag Coverage Δ
unittests 32.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonichi sonichi enabled auto-merge January 25, 2024 16:54
@sonichi sonichi added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 6bf6257 Jan 25, 2024
22 checks passed
@sonichi sonichi deleted the fix-deploy-website branch January 25, 2024 17:22
quantum-ciphers pushed a commit to quantum-ciphers/autogen that referenced this pull request Jan 26, 2024
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants