-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test permissions #1264
test permissions #1264
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
===========================================
+ Coverage 32.44% 45.18% +12.74%
===========================================
Files 40 40
Lines 4904 4904
Branches 1119 1185 +66
===========================================
+ Hits 1591 2216 +625
+ Misses 3187 2504 -683
- Partials 126 184 +58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does line 93 in deploy-website.yml require more permissions?
pages Work with GitHub Pages. For example, pages: write permits an action to request a GitHub Pages build. For more information, see "Permissions required for GitHub Apps."
If there is no code or doc change from this PR, we just need to make sure it's up-to-date with main and force run deploy_website.yml and see. |
added write permission on pages for deploy_website.yml Based on another microsoft repo: https://github.com/microsoft/BCApps/blob/main/.github/workflows/DeployReferenceDocumentation.yaml#L6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try.
* test permissions * test least permissions * remove contents permissions * testing permisions * Update deploy-website.yml permission block --------- Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
* test permissions * test least permissions * remove contents permissions * testing permisions * Update deploy-website.yml permission block --------- Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
* test permissions * test least permissions * remove contents permissions * testing permisions * Update deploy-website.yml permission block --------- Co-authored-by: Davor Runje <[email protected]> Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Chi Wang <[email protected]>
Why are these changes needed?
Related issue number
Closes #1223
Checks