Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test permissions #1264

Merged
merged 8 commits into from
Jan 24, 2024
Merged

test permissions #1264

merged 8 commits into from
Jan 24, 2024

Conversation

olaoluwasalami
Copy link
Collaborator

@olaoluwasalami olaoluwasalami commented Jan 15, 2024

Why are these changes needed?

Related issue number

Closes #1223

Checks

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (708eb4d) 32.44% compared to head (653a4ac) 45.18%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1264       +/-   ##
===========================================
+ Coverage   32.44%   45.18%   +12.74%     
===========================================
  Files          40       40               
  Lines        4904     4904               
  Branches     1119     1185       +66     
===========================================
+ Hits         1591     2216      +625     
+ Misses       3187     2504      -683     
- Partials      126      184       +58     
Flag Coverage Δ
unittests 45.12% <ø> (+12.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does line 93 in deploy-website.yml require more permissions?

https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/workflow-syntax-for-github-actions#permissions

pages Work with GitHub Pages. For example, pages: write permits an action to request a GitHub Pages build. For more information, see "Permissions required for GitHub Apps."

@sonichi sonichi requested a review from a team January 22, 2024 04:05
@ekzhu
Copy link
Collaborator

ekzhu commented Jan 22, 2024

If there is no code or doc change from this PR, we just need to make sure it's up-to-date with main and force run deploy_website.yml and see.

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 22, 2024

added write permission on pages for deploy_website.yml

Based on another microsoft repo: https://github.com/microsoft/BCApps/blob/main/.github/workflows/DeployReferenceDocumentation.yaml#L6

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try.

@sonichi sonichi marked this pull request as ready for review January 24, 2024 21:50
@sonichi sonichi added this pull request to the merge queue Jan 24, 2024
Merged via the queue into microsoft:main with commit bcfd770 Jan 24, 2024
100 of 110 checks passed
quantum-ciphers pushed a commit to quantum-ciphers/autogen that referenced this pull request Jan 26, 2024
* test permissions

* test least permissions

* remove contents permissions

* testing permisions

* Update deploy-website.yml permission block

---------

Co-authored-by: Davor Runje <[email protected]>
Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
corleroux pushed a commit to corleroux/autogen that referenced this pull request Jan 30, 2024
* test permissions

* test least permissions

* remove contents permissions

* testing permisions

* Update deploy-website.yml permission block

---------

Co-authored-by: Davor Runje <[email protected]>
Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* test permissions

* test least permissions

* remove contents permissions

* testing permisions

* Update deploy-website.yml permission block

---------

Co-authored-by: Davor Runje <[email protected]>
Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Update workflows with permissions block.
5 participants