Skip to content

[tests] Re-enable some quarantined tests that haven't been failing #8615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radical merged 4 commits into from
Apr 8, 2025
Merged

[tests] Re-enable some quarantined tests that haven't been failing #8615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
82604bd
[tests] Re-enable some quarantined tests that haven't been failing
radical Apr 8, 2025
072c8a9
fix build
radical Apr 8, 2025
36b583c
Re-enable some tests in Aspire.Hosting.Tests.DistributedApplicationTests
radical Apr 8, 2025
71917c1
Aspire.Hosting.Tests is taking longer than 10mins to run. Bump the se…
radical Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/Aspire.Dashboard.Tests/Integration/Playwright/AppBarTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ await AsyncTestHelpers.AssertIsTrueRetryAsync(
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7943")]
public async Task AppBar_Change_Theme_ReloadPage()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion tests/Aspire.Hosting.Testing.Tests/TestingBuilderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ public async Task GetHttpClientBeforeStart(bool genericEntryPoint)
[InlineData(false, true)]
[InlineData(true, false)]
[InlineData(true, true)]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7930")]
public async Task ArgsPropagateToAppHostConfiguration(bool genericEntryPoint, bool directArgs)
{
string[] args = directArgs ? ["APP_HOST_ARG=42"] : [];
Expand Down
2 changes: 0 additions & 2 deletions tests/Aspire.Hosting.Tests/Health/ResourceHealthCheckServiceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ await app.ResourceNotifications.PublishUpdateAsync(resource.Resource, s => s wit
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8326")]
public async Task ResourcesWithHealthCheck_CreationErrorIsReported()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down Expand Up @@ -138,7 +137,6 @@ await app.ResourceNotifications.PublishUpdateAsync(resource.Resource, s => s wit
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8103")]
public async Task ResourcesWithHealthCheck_StopsAndRestartsMonitoringWithResource()
{
using var builder = TestDistributedApplicationBuilder.Create(testOutputHelper);
Expand Down
1 change: 0 additions & 1 deletion tests/Aspire.Hosting.Tests/OperationModesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ namespace Aspire.Hosting.Tests;
public class OperationModesTests(ITestOutputHelper outputHelper)
{
[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8400")]
public async Task VerifyBackwardsCompatableRunModeInvocation()
{
// The purpose of this test is to verify that the apphost executable will continue
Expand Down
3 changes: 0 additions & 3 deletions tests/Aspire.Hosting.Tests/SlimTestProgramTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ public SlimTestProgramTests(SlimTestProgramFixture slimTestProgramFixture)
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
public async Task TestProjectStartsAndStopsCleanly()
{
var testProgram = _slimTestProgramFixture.TestProgram;
Expand All @@ -44,7 +43,6 @@ private static async Task EnsureServicesAreRunning(TestProgram testProgram, Canc
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatch()
{
var testProgram = _slimTestProgramFixture.TestProgram;
Expand All @@ -63,7 +61,6 @@ public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatc
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/7923")]
public async Task TestPortOnEndpointAnnotationAndAllocatedEndpointAnnotationMatchForReplicatedServices()
{
var testProgram = _slimTestProgramFixture.TestProgram;
Expand Down
3 changes: 0 additions & 3 deletions tests/Aspire.Hosting.Tests/WithHttpCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@ public async Task WithHttpCommand_ResultsInExpectedResultForStatusCode(int statu
[InlineData("get", true)]
[InlineData("post", false)]
[Theory]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8514")]
public async Task WithHttpCommand_ResultsInExpectedResultForHttpMethod(string? httpMethod, bool expectSuccess)
{
// Arrange
Expand Down Expand Up @@ -263,7 +262,6 @@ public async Task WithHttpCommand_UsesEndpointSelector()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8192")]
public async Task WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingRequest()
{
// Arrange
Expand Down Expand Up @@ -308,7 +306,6 @@ public async Task WithHttpCommand_CallsPrepareRequestCallback_BeforeSendingReque
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspire/issues/8200")]
public async Task WithHttpCommand_CallsGetResponseCallback_AfterSendingRequest()
{
// Arrange
Expand Down