[release/13.5] Fix dashboard graph rendering for multi-path icons - #19585
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19585Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19585" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Fixes dashboard Graph view failures when Fluent UI icons contain multiple SVG paths.
Changes:
- Parses icon content as an SVG fragment.
- Combines sibling path data into one compound path.
- Adds regression tests for single- and multi-path icons.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Aspire.Dashboard/Model/ResourceGraph/ResourceGraphMapper.cs |
Supports multi-path Fluent UI icons. |
tests/Aspire.Dashboard.Tests/Model/ResourceGraphMapperTests.cs |
Covers both icon shapes. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
PR #19585 Testing ReportResultThe dashboard fix is verified with the PR dogfood binary. Aspire 13.5.1 reproduces the original multi-path icon crash with the same AppHost. CI is failing for an unrelated deterministic CLI E2E test-harness issue. On all four attempts, two Artifact Verification
CI Failure AnalysisThe failing test jobs are:
Both recordings show the project update finishing, followed by: The automator did not expect this post-update prompt, so it waited for the shell success prompt for about 500 seconds. MTP then reached its 10-minute hang-dump timeout, killed the test host, and reported exit codes 137/7 with no completed test results. This prompt now appears because stable The PR changes only Side-by-Side Dashboard ReproductionBoth fresh single-file AppHosts used the same resource: builder.AddExecutable("multi-path-icon", "sleep", ".", "300")
.WithIconName("DocumentMultiple");
PR dogfood
Aspire 13.5.1
Evidence
OverallDashboard fix verified. PR #19585 correctly handles multi-path Fluent UI icons. The red CI status is caused by unrelated CLI E2E prompt handling. ScreenshotsPR #19585 dogfood — graph rendersAspire 13.5.1 — graph crashes |
|
Mitch Denny (@mitchdenny) two tests are failing on Update: Apparently that's accepted on this branch |
Jose Perez Rodriguez (joperezr)
left a comment
There was a problem hiding this comment.
Thanks for fixing Seb, approved.
Tests selector (audit mode)The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement. Runs the full test matrix + all jobs (ALL) — a rule matching 'eng/Versions.props' selects ALL Selection computed for commit |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
9e2f792
into
release/13.5
|
✅ No documentation update needed. Step 5 branch taken: excluded → backport This PR is a backport (release/13.5) of #19579. Exclusion reasons from signals.json: No signals triggered (signal_count: 0). Documentation for this fix should be authored against the original forward PR (#19579) on the default branch, not duplicated here. |


Backport of #19579 to release/13.5
/cc Sébastien Ros (@sebastienros)
Customer Impact
Dahboard failures
Testing
Local verification of PR build succesfull and published
Risk
Low
Regression?
Yes