Fix dashboard graph rendering for multi-path icons by sebastienros · Pull Request #19579 · microsoft/aspire

Sébastien Ros (sebastienros) · 2026-08-21T21:17:00Z

Description

The Dashboard Graph view crashes when an AppHost uses AddBlobs because its DocumentMultiple icon contains multiple sibling SVG paths, while the graph mapper expects one XML root.

This parses Fluent UI icon content as an SVG fragment and combines each path's data into one compound SVG path, preserving the existing graph DTO and JavaScript rendering contract.

User-facing usage

AppHosts with Azure Blob resources can switch to Graph view without breaking the dashboard circuit:

var storage = builder.AddAzureStorage("storage")
    .RunAsEmulator();

storage.AddBlobs("blobs");

Targeted ResourceGraphMapperTests cover both single-path icons and the multi-path DocumentMultiple icon.

Fixes: #19489

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-08-21T21:17:18Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19579

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19579"

github-actions · 2026-08-21T21:19:33Z

Tests selector (audit mode)

The full test matrix and all jobs still run in audit mode. The tests and jobs below are what selective CI would run under enforcement.

8 / 102 test projects · 4 jobs, from 2 changed files.

Selected test projects (8 / 102)

Aspire.Cli.EndToEnd.Tests, Aspire.Dashboard.Components.Tests, Aspire.Dashboard.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Testing.Tests, Aspire.Managed.Tests, Aspire.Playground.Tests

Selected jobs (4)

cli-starter, deployment-e2e, extension-e2e, polyglot

How these were chosen — grouped by what changed

🔧 src/Aspire.Dashboard/Model/ResourceGraph/ResourceGraphMapper.cs (changed source)
→ 6 via the project graph: Aspire.Dashboard.Components.Tests, Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.RemoteHost.Tests (2 hops), Aspire.Hosting.Testing.Tests, Aspire.Managed.Tests (2 hops), Aspire.Playground.Tests (2 hops)

📦 affected project Aspire.Managed
→ 1 test: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Dashboard.Tests/Model/ResourceGraphMapperTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Tests

Job reasons

Job	Triggered by
`cli-starter`	• affected project `Aspire.Managed` • selected test `Aspire.Cli.EndToEnd.Tests`
`deployment-e2e`	affected project `Aspire.Managed`
`extension-e2e`	• `src/Aspire.Dashboard/Model/ResourceGraph/ResourceGraphMapper.cs` • affected project `Aspire.Dashboard`
`polyglot`	affected project `Aspire.Managed`

Selection computed for commit 1673909.

Copilot

Pull request overview

Fixes Graph view crashes caused by Fluent UI icons containing multiple sibling SVG paths.

Changes:

Parses icon content as an SVG fragment and combines path data.
Adds regression tests for single-path and multi-path icons.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
`src/Aspire.Dashboard/Model/ResourceGraph/ResourceGraphMapper.cs`	Supports compound icon paths.
`tests/Aspire.Dashboard.Tests/Model/ResourceGraphMapperTests.cs`	Tests both icon shapes.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Sébastien Ros (sebastienros) · 2026-08-21T21:45:57Z

PR Testing Report

PR Information

PR Number: Fix dashboard graph rendering for multi-path icons #19579
Title: Fix dashboard graph rendering for multi-path icons
Head Commit: 1673909da134614a1f1374602ed242ec26ece46c
Base Commit: c1d2831ade34a050e8ea1111ac64aeda67c7321e
Tested At: 2026-08-21T21:43:48Z

Artifact Version Verification

Expected Commit: 1673909da134614a1f1374602ed242ec26ece46c
Installed Version: 13.6.0-pr.19579.g1673909d
Status: PASS - the installed dogfood CLI matches the PR head.

Changes Analyzed

Files Changed

src/Aspire.Dashboard/Model/ResourceGraph/ResourceGraphMapper.cs
tests/Aspire.Dashboard.Tests/Model/ResourceGraphMapperTests.cs

Change Categories

Test Scenarios Executed

Scenario 1: Reproduce the bug before the fix

Objective: Prove the PR base has the exact failure reported in issue #19489.

Coverage Type: Regression baseline

Status: PASS - bug reproduced.

Steps:

Created an isolated source worktree at base commit c1d2831a.
Added a temporary focused test that calls ResourceGraphMapper.GetIconPathData with the real Icons.Filled.Size24.DocumentMultiple icon.
Ran only that test through Microsoft.Testing.Platform.

Observed:

The test failed at ResourceGraphMapper.cs:90 with:

System.Xml.XmlException: There are multiple root elements. Line 1, position 142.

This matches the issue stack trace and confirms the base code cannot parse the icon assigned by AddBlobs.

Evidence:

evidence/pre-fix-repro.log
evidence/pre-fix-test-exit-code.txt

Scenario 2: Validate the post-fix mapper

Objective: Confirm the PR handles both existing single-path icons and DocumentMultiple.

Coverage Type: Focused unit regression

Status: PASS

Steps:

Ran ResourceGraphMapperTests at PR head.
Excluded quarantined and outerloop tests.

Observed:

All 9 focused tests passed, including the single-path and three-path icon cases.

Evidence:

evidence/post-fix-tests.log

Scenario 3: Render `AddBlobs` in the Dashboard Graph view

Objective: Verify the user-visible issue is fixed in the PR dogfood Dashboard.

Coverage Type: Happy path, browser E2E

Status: PASS

Steps:

Created a fresh C# aspire-empty AppHost from the PR package hive.
Added Aspire.Hosting.Azure.Storage at the PR version.
Added the issue's Azure Storage emulator and storage.AddBlobs("blobs") resource graph.
Started the AppHost with the verified PR CLI.
Opened the Dashboard with Playwright Firefox and selected Graph view.

Observed:

The graph rendered 3 nodes: blobs, azure-environment, and storage.
The blobs node had non-empty combined SVG path data.
No reconnect dialog was visible.
A clean browser session reported no console errors.
The final AppHost log contained no XmlException, multiple root elements, or unhandled circuit exception.

The local machine did not have a trusted development certificate, so the final browser scenario used the generated AppHost's HTTP launch profile with ASPIRE_ALLOW_UNSECURED_TRANSPORT=true. This changes only local test transport; the PR's graph parsing and rendering path is unchanged.

Evidence:

evidence/final-clean-graph-result.txt
evidence/final-graph-view.png
evidence/final-browser-console-errors.txt
evidence/final-graph-exception-scan.txt
evidence/final-apphost.log
evidence/final-resources.json

Scenario 4: Repeated navigation and circuit recovery boundary

Objective: Confirm Graph view does not poison the Blazor circuit after rendering the multi-path icon.

Coverage Type: Boundary/recovery

Status: PASS

Steps:

Switched between Resources and Graph views 3 times.
Verified all 3 graph nodes rendered after every switch.
Returned to Resources and opened the blobs resource details.

Observed:

Every Graph view rendered all expected nodes.
Blob resource details opened successfully.
The Dashboard remained responsive with no visible reconnect dialog.

Evidence:

evidence/recovery-navigation-result.txt
evidence/resource-details-after-graph.png

Summary

Scenario	Status	Notes
Pre-fix reproduction	PASS	Exact `multiple root elements` exception reproduced
Post-fix mapper tests	PASS	9/9 focused tests passed
Dashboard Graph view	PASS	All 3 nodes rendered, including `blobs`
Repeated navigation/details	PASS	Circuit remained responsive

Overall Result

PR VERIFIED

The bug reproduces on the PR base and is fixed at the PR head in both focused mapper coverage and a real dogfood Dashboard browser scenario.

Sébastien Ros (sebastienros) · 2026-08-21T22:13:26Z

/backport to release/13.5

github-actions · 2026-08-21T22:13:38Z

Started backporting to release/13.5 (link to workflow run)

github-actions · 2026-08-21T22:22:13Z

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Yamin (yaminmirworld-source)

Good

Fix dashboard graph multi-path icons

1673909

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings August 21, 2026 21:17

github-actions Bot added the area-dashboard label Aug 21, 2026

Copilot started reviewing on behalf of Sébastien Ros (sebastienros) August 21, 2026 21:17 View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Sébastien Ros (sebastienros) marked this pull request as ready for review August 21, 2026 21:47

Sébastien Ros (sebastienros) requested review from James Newton-King (JamesNK) and Adam Ratzman (adamint) as code owners August 21, 2026 21:47

Sébastien Ros (sebastienros) added this to the 13.5 milestone Aug 21, 2026

James Newton-King (JamesNK) approved these changes Aug 21, 2026

View reviewed changes

Adam Ratzman (adamint) enabled auto-merge (squash) August 21, 2026 22:04

aspire-repo-bot Bot mentioned this pull request Aug 21, 2026

[release/13.5] Fix dashboard graph rendering for multi-path icons #19585

Merged

Adam Ratzman (adamint) merged commit 0659efd into main Aug 21, 2026
760 of 763 checks passed

Adam Ratzman (adamint) deleted the sebros/fix-dashboard-graph-multiple-roots branch August 21, 2026 22:28

github-actions Bot modified the milestones: 13.5, 13.6 Aug 21, 2026

github-actions Bot mentioned this pull request Aug 22, 2026

[repo-pulse] 📊 Repo Pulse — Daily Activity Dashboard #16404

Open

Yamin (yaminmirworld-source) reviewed Aug 26, 2026

View reviewed changes

Navigation Menu

Uh oh!

Fix dashboard graph rendering for multi-path icons - #19579

Fix dashboard graph rendering for multi-path icons#19579
Adam Ratzman (adamint) merged 1 commit into
mainfrom
sebros/fix-dashboard-graph-multiple-roots

Sébastien Ros (sebastienros) commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Job reasons

Uh oh!

Copilot AI left a comment

Uh oh!

Sébastien Ros (sebastienros) commented Aug 21, 2026

Uh oh!

Sébastien Ros (sebastienros) commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

Uh oh!

Yamin (yaminmirworld-source) left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Sébastien Ros (sebastienros) commented Aug 21, 2026

Description

User-facing usage

Checklist

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Tests selector (audit mode)

Selected test projects (8 / 102)

Selected jobs (4)

Job reasons

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Sébastien Ros (sebastienros) commented Aug 21, 2026

PR Testing Report

PR Information

Artifact Version Verification

Changes Analyzed

Files Changed

Change Categories

Test Scenarios Executed

Scenario 1: Reproduce the bug before the fix

Scenario 2: Validate the post-fix mapper

Scenario 3: Render AddBlobs in the Dashboard Graph view

Scenario 4: Repeated navigation and circuit recovery boundary

Summary

Overall Result

Uh oh!

Sébastien Ros (sebastienros) commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

github-actions Bot commented Aug 21, 2026

Uh oh!

Uh oh!

Yamin (yaminmirworld-source) left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Scenario 3: Render `AddBlobs` in the Dashboard Graph view