Skip to content

Enable building of extensions in the internal build pipeline using property directly instead of switch #11678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joperezr merged 2 commits into from
Sep 26, 2025
Merged

Enable building of extensions in the internal build pipeline using property directly instead of switch #11678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db0d89
Enable building of extensions in the internal build pipeline using pr…
joperezr Sep 26, 2025
efac995
Update eng/pipelines/azure-pipelines.yml
joperezr Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ extends:
autoEnablePREfastWithNewRuleset: false
autoEnableRoslynWithNewRuleset: false
sdl:
policheck:
policheck:-
Comment thread
joperezr marked this conversation as resolved.
Outdated
Comment thread
joperezr marked this conversation as resolved.
Outdated
enabled: true
exclusionsFile: $(Build.SourcesDirectory)\.config\PoliCheckExclusions.xml
eslint:
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/templates/BuildAndTest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ steps:
-restore -build
-pack
-sign $(_SignArgs)
-buildExtension
-publish $(_PublishArgs)
-configuration ${{ parameters.buildConfig }}
/bl:${{ parameters.repoLogPath }}/build.binlog
$(_OfficialBuildIdArgs)
$(_InternalBuildArgs)
/p:TargetRids=${{ join(':', parameters.targetRids) }}
/p:SkipTestProjects=true
/p:BuildExtension=true

@radical radical Sep 26, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also go ahead and remove the -buildExtension, and --build-extension params from the sh and ps1 scripts?

@davidfowl davidfowl Sep 26, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Don't we want this for PRs?

@joperezr joperezr Sep 26, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash I think is working fine with the switch (at least that seemed to be the case locally). I do think that this should be cleaned up but perhaps we do want to actually fix it so the switch is supported? I'll leave that up to @adamint but I think we should not block this PR on that as currently the builds from main are broken.

displayName: 🟣Build

- task: 1ES.PublishBuildArtifacts@1
Expand Down
Loading