Enable building of extensions in the internal build pipeline using property directly instead of switch#11678
Conversation
…operty directly instead of switch
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 11678Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 11678" |
There was a problem hiding this comment.
Pull Request Overview
This change fixes broken official builds by modifying how extensions are built in the internal build pipeline. Instead of using a switch parameter that isn't being handled correctly after arcade build script updates, the change passes the property directly to the build command.
- Removes the
-buildExtensionswitch from the build command - Adds
/p:BuildExtension=trueproperty to directly enable extension building - Includes a minor formatting fix in the azure-pipelines.yml file
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/pipelines/templates/BuildAndTest.yml | Replaces -buildExtension switch with /p:BuildExtension=true property |
| eng/pipelines/azure-pipelines.yml | Minor formatting fix for policheck configuration |
| $(_InternalBuildArgs) | ||
| /p:TargetRids=${{ join(':', parameters.targetRids) }} | ||
| /p:SkipTestProjects=true | ||
| /p:BuildExtension=true |
There was a problem hiding this comment.
Should we also go ahead and remove the -buildExtension, and --build-extension params from the sh and ps1 scripts?
There was a problem hiding this comment.
Why? Don't we want this for PRs?
There was a problem hiding this comment.
bash I think is working fine with the switch (at least that seemed to be the case locally). I do think that this should be cleaned up but perhaps we do want to actually fix it so the switch is supported? I'll leave that up to @adamint but I think we should not block this PR on that as currently the builds from main are broken.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Description
Official builds are currently broken since arcade updated the build scripts that were edited in this change: #11504 causing the buildExtension switch to not be handled correctly. Instead of trying to pass in a switch, this change just directly passes in the property to the build which will make it so the extension gets built.
FYI: @radical @adamint
Checklist