Skip to content

aspire config set writes appHostPath to ~/.aspire/settings.json globally, causing incorrect path resolution #10700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchdenny merged 2 commits into from
Jul 28, 2025
Merged

aspire config set writes appHostPath to ~/.aspire/settings.json globally, causing incorrect path resolution #10700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe13de
Initial plan
Copilot Jul 28, 2025
67cd7af
Rename global settings file from settings.json to globalsettings.json
Copilot Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Aspire.Cli/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class Program
private static string GetGlobalSettingsPath()
{
var homeDirectory = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);
var globalSettingsPath = ConfigurationHelper.BuildPathToSettingsJsonFile(homeDirectory);
var globalSettingsPath = Path.Combine(homeDirectory, ".aspire", "globalsettings.json");
Comment on lines 43 to +44
Copy link

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the filename 'globalsettings.json' here creates a discrepancy with the ConfigurationHelper.BuildPathToSettingsJsonFile() method that was previously used. Consider creating a constant or method to ensure consistency across the codebase for the global settings filename.

Copilot uses AI. Check for mistakes.
return globalSettingsPath;
}

Expand Down
Loading