Initial commit of Reunion Common Entrypoint #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwis
commented
May 7, 2020
kennykerr
reviewed
May 7, 2020
kennykerr
reviewed
May 7, 2020
kennykerr
reviewed
May 7, 2020
| @@ -0,0 +1,269 @@ | |||
| ## Ignore Visual Studio temporary files, build results, and | |||
There was a problem hiding this comment.
Not a fan of the kitchen sink .gitignore that Visual Studio generates. I'd rather be deliberate about what I ignore.
There was a problem hiding this comment.
Most of this is probably unneeded if you also pick up the directory.props and other root configurations that make sure all the VS generated goop is in the root "BuildOutput" folder. VS generates quite a lot of nonsense into the source tree if you aren't careful though and I feel this is safer than folks accidentally blowing up the remote git repo with binary blobs that are never meant to be checked in.
jevansaks
reviewed
May 8, 2020
| {A4412A57-CECE-4494-A873-CCBBA5C6E9E6}.Debug|x86.ActiveCfg = Debug|Win32 | ||
| {A4412A57-CECE-4494-A873-CCBBA5C6E9E6}.Debug|x86.Build.0 = Debug|Win32 | ||
| {A4412A57-CECE-4494-A873-CCBBA5C6E9E6}.Release|ARM.ActiveCfg = Release|ARM | ||
| {A4412A57-CECE-4494-A873-CCBBA5C6E9E6}.Release|ARM.Build.0 = Release|ARM |
There was a problem hiding this comment.
We should make sure we have ARM64 configs from the get-go.
jevansaks
approved these changes
May 8, 2020
Closed
This was referenced May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring up initial markdown documentation, solution, "common" type, and get things building.
Much more work to be done:
docs/content promised in the README