-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bootstrap C# API. Spec Bootstrap C# and get GenerationId (Flat-C/WinRT) APIs #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple DynDep projects under 1 parent (simplifies adding more, under the dir instead of scattered across the froot)
riverar
reviewed
Aug 20, 2021
dev/Bootstrap/CS/Microsoft.WindowsAppSDK.Bootstrap.Net/Bootstrap.cs
Outdated
Show resolved
Hide resolved
dev/Bootstrap/CS/Microsoft.WindowsAppSDK.Bootstrap.Net/Bootstrap.cs
Outdated
Show resolved
Hide resolved
dev/Bootstrap/CS/Microsoft.WindowsAppSDK.Bootstrap.Net/Bootstrap.cs
Outdated
Show resolved
Hide resolved
...tstrap/CS/Microsoft.WindowsAppSDK.Bootstrap.Net/Microsoft.WindowsAppSDK.Bootstrap.Net.csproj
Outdated
Show resolved
Hide resolved
Just some minor feedback. 👍 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
DrusTheAxe
requested review from
Scottj1s,
MikeHillberg,
aeloros and
alexlamtest
August 20, 2021 21:03
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dhoehna
approved these changes
Aug 30, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…ly xref'd via GUIDs making updates hard to understand let alone human intervention when merge conflicts arise)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ZenBird-zz
pushed a commit
that referenced
this pull request
Sep 4, 2021
…WinRT) APIs (#1274) * Moved DynamicDependency project into a subdir so I can collapse the multiple DynDep projects under 1 parent (simplifies adding more, under the dir instead of scattered across the froot) * Added 'GenerationId'. Added Bootstrap C# API * Added Bootstrap API samples * Fixed return type/calling convention of MddGetGenerationId() * Added C# API for Bootstrap API * Incorporated feedback * Removed redundant AnyCPU setting (it's the default if unspecified) * Incorporated feedback * Added the C# assembly to the Transport package * Removed accidental nuget reference * Moved the specs out to user/drustheaxe/spec-bootstrapcs-generationid * Fixed bad patah * Incorporated feedback * Fixed typo (sheepish grin) * Fixed bad merge * Fixed previous incomplete bad-merge-fix (Gah! VS .sln files are heavily xref'd via GUIDs making updates hard to understand let alone human intervention when merge conflicts arise) * More mergy fun * Update *WindowsAppSDK* to *WindowsAppRuntime* * Missed one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update spec for the Bootstrap C# API and Dynamic Dependency GenerationId property.
Spec @ Spec updates for GenerationId and Bootstrap C# API #1284
This PR also includes some internal maintenance (reorganizing some project layout).