Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap C# API. Spec Bootstrap C# and get GenerationId (Flat-C/WinRT) APIs #1274

Merged
merged 29 commits into from
Aug 31, 2021

Conversation

DrusTheAxe
Copy link
Member

@DrusTheAxe DrusTheAxe commented Aug 20, 2021

Update spec for the Bootstrap C# API and Dynamic Dependency GenerationId property.

Spec @ Spec updates for GenerationId and Bootstrap C# API #1284

This PR also includes some internal maintenance (reorganizing some project layout).

@DrusTheAxe DrusTheAxe added this to the 1.0 (2021 Q4) milestone Aug 20, 2021
@DrusTheAxe DrusTheAxe requested a review from jonwis August 20, 2021 06:18
@DrusTheAxe DrusTheAxe self-assigned this Aug 20, 2021
@ghost ghost added the needs-triage label Aug 20, 2021
@riverar
Copy link
Contributor

riverar commented Aug 20, 2021

Just some minor feedback. 👍

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe DrusTheAxe requested a review from ionvasilian August 28, 2021 06:55
@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

…ly xref'd via GUIDs making updates hard to understand let alone human intervention when merge conflicts arise)
@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DrusTheAxe DrusTheAxe dismissed jonwis’s stale review August 31, 2021 01:49

Addressed feedback. See comments

@DrusTheAxe DrusTheAxe merged commit aa4e265 into main Aug 31, 2021
@DrusTheAxe DrusTheAxe deleted the user/drustheaxe/cs-bootstrap branch August 31, 2021 01:50
ZenBird-zz pushed a commit that referenced this pull request Sep 4, 2021
…WinRT) APIs (#1274)

* Moved DynamicDependency project into a subdir so I can collapse the multiple DynDep projects under 1 parent (simplifies adding more, under the dir instead of scattered across the froot)

* Added 'GenerationId'. Added Bootstrap C# API

* Added Bootstrap API samples

* Fixed return type/calling convention of MddGetGenerationId()

* Added C# API for Bootstrap API

* Incorporated feedback

* Removed redundant AnyCPU setting (it's the default if unspecified)

* Incorporated feedback

* Added the C# assembly to the Transport package

* Removed accidental nuget reference

* Moved the specs out to user/drustheaxe/spec-bootstrapcs-generationid

* Fixed bad patah

* Incorporated feedback

* Fixed typo (sheepish grin)

* Fixed bad merge

* Fixed previous incomplete bad-merge-fix (Gah! VS .sln files are heavily xref'd via GUIDs making updates hard to understand let alone human intervention when merge conflicts arise)

* More mergy fun

* Update *WindowsAppSDK* to *WindowsAppRuntime*

* Missed one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants