Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Milestone M190 #1748

Merged
merged 69 commits into from
Jul 15, 2021
Merged

[Release] Milestone M190 #1748

merged 69 commits into from
Jul 15, 2021

Conversation

derrickstolee
Copy link
Contributor

@derrickstolee derrickstolee commented Jul 15, 2021

Major Updates

  • Comes with microsoft/git v2.32.0.vfs.0.4.
  • This release will be available via winget.
  • The gvfs upgrade verb is deprecated. Any future updates will be taken via winget.
  • This version of Git has an upgrade mechanism that can advance independently of VFS for Git. Run git update-microsoft-git to update your Git version.
  • The build system has been updated to use a more recent version of .NET.
  • All macOS and POSIX code has been removed to simplify the build system.
  • A FastFetch bug around deleting files has been fixed.
  • A prefetch bug around downloading a small number of files has been fixed.

Special thanks to contributors @ldennington, @tyrielv, @50Wliu, and @SteveBenz.

Pull Requests

derrickstolee and others added 30 commits March 24, 2021 08:11
I pushed all of the packages we need to our custom feed. Script included.
Signed-off-by: Derrick Stolee <[email protected]>
…iles

This fixes #1729 and also takes care of a performance problem in the same method.
Bumping mjcheetham/update-winget version
Signed-off-by: Derrick Stolee <[email protected]>
This includes the latest changes for `winget` installation and upgrading with `git update-microsoft-git`.
In testing, we see the installer hanging until the UI is killed.

```
[Environment]::SetEnvironmentVariable("GVFS_UNATTENDED", "1", "Machine")
Start-Process .\SetupGVFS.1.0.21085.9.exe -ArgumentList "/VERYSILENT", "/NORESTART", "/NOCANCEL", "/SP-", "/CLOSEAPPLICATIONS", "/RESTARTAPPLICATIONS", "/LOG=gvfs.log", "/SUPPRESSMSGBOXES" -Wait
# Hangs until GVFS.Service.UI is killed
```
Move the GitHooksLoader under the GVFS directory and migrate the project
file to v142 toolset (VS2019) and WinSDK10.0.16299. Also migrate project
to use new MSBuild properties for the VSF for Git project.
Drop the older custom targets and props files for the new ones.
Replace the GVFS.Build directory and pre-build code with targets and
tasks that are better integrated with the rest of the build.
Migrate the native VC++ projects to use the new build variables, package
restore, and WinSDK to 10.0.16299.
Also drop the .Windows specific project.. it's all Windows now.
mjcheetham and others added 21 commits June 28, 2021 15:52
Overhaul build and project systems and drop Mac/POSIX code
When I run the tests locally, these exits are hit every time. Something odd is happening.

Signed-off-by: Derrick Stolee <[email protected]>
This timer is responsible for checking if there is a new VFS for Git
version on a timer, then launches a notification to GVFS.Service.UI. I
was hoping to delete all of GVFS.Service.UI, but we need the toast
notifications for when we attempt to auto-mount and have a failure.

Signed-off-by: Derrick Stolee <[email protected]>
This leaves 'gvfs upgrade' non-functional

Signed-off-by: Derrick Stolee <[email protected]>
Remove all code for the custom upgrader that ran the installer either from GitHub or from a NuGet feed.

This leaves `gvfs upgrade` non-functional, but a replacement will follow that calls `winget upgrade vfsforgit`.
Signed-off-by: Derrick Stolee <[email protected]>
In testing, we see the installer hanging until the UI is killed.

```pwsh
[Environment]::SetEnvironmentVariable("GVFS_UNATTENDED", "1", "Machine")
Start-Process .\SetupGVFS.1.0.21085.9.exe -ArgumentList "/VERYSILENT", "/NORESTART", "/NOCANCEL", "/SP-", "/CLOSEAPPLICATIONS", "/RESTARTAPPLICATIONS", "/LOG=gvfs.log", "/SUPPRESSMSGBOXES" -Wait
# Hangs until GVFS.Service.UI is killed
```

Note, this is my first ever time editing an Inno Setup script or working with Pascal, so I may have gotten some things wrong :).

Fixes #1739.
…eriod when prefetching

Fix for #1743 - do not exit early if no blobs found for a period when prefetching.
We removed the old upgrader in #1746 but delayed creating its replacement.

The plan was to use `winget upgrade`, but it is only experimental right now. Further, we would need to use `winget list` to determine if we needed `winget install` instead, and `winget list` is also experimental. The tool needs to mature more before we can create a dependency on it.

Instead, warn a user that tries to upgrade with `gvfs upgrade` that this CLI is no longer supported and instead point them to the repository's README which can help with the latest update.
Applying fix to prevent PRs into winget-pkgs from default branch of forks. See mjcheetham/update-winget#107 for more details.
@derrickstolee derrickstolee self-assigned this Jul 15, 2021
@derrickstolee
Copy link
Contributor Author

A lot of the PR merge commits look like they have broken builds, but this is because I had forgotten to disable the CI trigger on the old Azure Pipelines builds.

@derrickstolee derrickstolee merged commit d6d96fd into releases/shipped Jul 15, 2021
@winstliu
Copy link
Member

@derrickstolee question - in the release notes you wrote "This release will be available via winget". Will the release also be published to GitHub, i.e. https://github.com/microsoft/VFSForGit/releases, or will it be available only through winget?
(As an addendum, has this release been published yet? Strangely I don't have winget installed so I can't check, even though I'm running Insider builds.)

@derrickstolee
Copy link
Contributor Author

Hi, @50Wliu. The release will also be available on the releases page. This release got cut short during our pipelines for generating the signed builds, and we might delay the full release until Git 2.33.0 is release in August. Thanks for your interest!

@winstliu
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants