Delete custom upgrader #1746
Merged
Delete custom upgrader #1746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This timer is responsible for checking if there is a new VFS for Git version on a timer, then launches a notification to GVFS.Service.UI. I was hoping to delete all of GVFS.Service.UI, but we need the toast notifications for when we attempt to auto-mount and have a failure. Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee
force-pushed
the
gvfs-upgrade
branch
from
adc5c75 to
fdd308c
Compare
This leaves 'gvfs upgrade' non-functional Signed-off-by: Derrick Stolee <[email protected]>
derrickstolee
force-pushed
the
gvfs-upgrade
branch
from
fdd308c to
a17c95a
Compare
derrickstolee
added a commit
that referenced
this pull request
Jul 14, 2021
We removed the old upgrader in #1746 but delayed creating its replacement. The plan was to use `winget upgrade`, but it is only experimental right now. Further, we would need to use `winget list` to determine if we needed `winget install` instead, and `winget list` is also experimental. The tool needs to mature more before we can create a dependency on it. Instead, warn a user that tries to upgrade with `gvfs upgrade` that this CLI is no longer supported and instead point them to the repository's README which can help with the latest update.
This was referenced Jul 14, 2021
derrickstolee
added a commit
that referenced
this pull request
Jul 15, 2021
Major Updates ---------------- * Comes with `microsoft/git` v2.32.0.vfs.0.4. * This release will be available via `winget`. * The `gvfs upgrade` verb is deprecated. Any future updates will be taken via `winget`. * This version of Git has an upgrade mechanism that can advance independently of VFS for Git. Run `git update-microsoft-git` to update your Git version. * The build system has been updated to use a more recent version of .NET. * All macOS and POSIX code has been removed to simplify the build system. * A FastFetch bug around deleting files has been fixed. * A prefetch bug around downloading a small number of files has been fixed. Special thanks to contributors @ldennington, @tyrielv, @50Wliu, and @SteveBenz. Pull Requests --------------- * #1738: Bumping version of update-winget action * #1747: UpgradeVerb: write deprecation notice * #1745: do not exit early if no blobs found for a period when prefetching * #1740: Skip launching UI if running unattended * #1737: Update Git to v2.32.0 * #1746: Delete custom upgrader * #1741: Fix winget tag specification * #1744: Overhaul build and project systems and drop Mac/POSIX code * #1736: Update Git to v2.31.1.vfs.0.3 * #1735: Bumping winget action version * #1734: Adding winget workflow * #1733: Update Git to include 2.31.1 * #1730: Fix an issue with FastFetch when deleting files * #1732: Use one NuGet feed * #1726: Config: commitGraph.generationVersion=1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code for the custom upgrader that ran the installer either from GitHub or from a NuGet feed.
This leaves
gvfs upgradenon-functional, but a replacement will follow that callswinget upgrade vfsforgit.