Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync the dom.generated.d.ts files from TSJS repo #5836

Merged
merged 1 commit into from
Dec 1, 2015

Conversation

zhengbli
Copy link
Contributor

Contains fixes for:
#5533
#3583
#1558
#1253
#5813

@yuit
Copy link
Contributor

yuit commented Nov 30, 2015

lgtm

@mhegazy mhegazy added the Breaking Change Would introduce errors in existing code label Dec 1, 2015
@mhegazy mhegazy added this to the TypeScript 1.8 milestone Dec 1, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2015

👍

@sparecycles
Copy link
Contributor

@mhegazy

Curious, what's the strategy for syncing up the other 4 files? In my PR I changed one declaration in 6 files, #5859, but only two of those files are covered in this PR.

@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2015

there are sources (src\lib*.d.ts), that are used to generate the output (build\local*.d.ts and lib*.d.ts), you only need to update the sources, the build (jake lib) will generate the outputs.
you can find more details at: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes

zhengbli added a commit that referenced this pull request Dec 1, 2015
Sync the dom.generated.d.ts files from TSJS repo
@zhengbli zhengbli merged commit 5e86ca1 into microsoft:master Dec 1, 2015
@mhegazy mhegazy added the Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript label Jan 26, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Would introduce errors in existing code Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants