Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLTableElement Functions return wrong types (insertRow, insertCell) #1274

Closed
EricLambrecht opened this issue Nov 26, 2014 · 3 comments
Closed
Assignees
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created

Comments

@EricLambrecht
Copy link

insertRow(index?: number): HTMLElement;
insertRow(index?: number): HTMLTableRowElement ;
insertCell(index?: number): HTMLElement;
insertCell(index?: number): HTMLTableCellElement;

also HTMLTableElement.rows is not a collection of HTMLTableRowElements!?

Am I mistaken here?

@EricLambrecht EricLambrecht changed the title HTMLTableElement Functions return wrong interfaces (insertRow, insertCell) HTMLTableElement Functions return wrong types (insertRow, insertCell) Nov 26, 2014
@RyanCavanaugh RyanCavanaugh added Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Revisit An issue worth coming back to Bug A bug in TypeScript labels Nov 26, 2014
@RyanCavanaugh
Copy link
Member

lib.d.ts is auto-generated from the spec and the W3C doesn't specify that this must return a cell (though I suspect it always does!). http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-68927016

We should probably patch this specific one, though.

@EricLambrecht
Copy link
Author

Aaah, didn't know that. But thank you, patching this would be awesome!

@mhegazy mhegazy added this to the TypeScript 2.0 milestone Dec 3, 2014
@mhegazy mhegazy self-assigned this Dec 3, 2014
@mhegazy mhegazy modified the milestones: TypeScript 2.0, TypeScript 1.6 Apr 2, 2015
@mhegazy mhegazy modified the milestones: TypeScript 1.6, TypeScript 1.7 Jul 1, 2015
@mhegazy mhegazy modified the milestones: TypeScript 2.0, TypeScript 1.7 Oct 6, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Dec 1, 2015

duplicate of #3583, and should be fixed in #5836

@mhegazy mhegazy closed this as completed Dec 1, 2015
@mhegazy mhegazy added Duplicate An existing issue was already created and removed Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Revisit An issue worth coming back to labels Dec 1, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants