Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsc): Add typings for Intl.ListFormat #13301

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

andreubotella
Copy link
Contributor

@andreubotella andreubotella commented Jan 7, 2022

V8 has supported Intl.ListFormat since version 7.2, but TypeScript doesn't have typings for it yet. This PR manually adds those typings, copying them from microsoft/TypeScript#47254.

Fixes #13199.

V8 has supported `Intl.ListFormat` since version 7.2, but TypeScript doesn't
have typings for it yet. This PR manually adds those typings, copying them from
microsoft/TypeScript#47254.

Fixes denoland#13199.
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these declarations should be added to lib.deno.shared_globals.d.ts

@andreubotella
Copy link
Contributor Author

As per the conversation on Discord, it's fine to declare this in lib.es2021.intl.d.ts, so this can be merged.

@bartlomieju bartlomieju merged commit 76c7b9a into denoland:main Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ListFormat types?
2 participants