Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update es2020.intl DisplayNames#of #47157

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

tao-cumplido
Copy link
Contributor

fix return type of Intl.DisplayNames.prototype.of
was typed to return always string but can actually return undefined too
see spec https://tc39.es/ecma402/#sec-Intl.DisplayNames.prototype.of

Fixes #47143

fix return type of Intl.DisplayNames.prototype.of
was typed to return always string but can actually return undefined too
see spec https://tc39.es/ecma402/#sec-Intl.DisplayNames.prototype.of
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Dec 15, 2021
@orta
Copy link
Contributor

orta commented Dec 15, 2021

Thanks!

@orta orta merged commit 2bbdb31 into microsoft:main Dec 15, 2021
mprobst pushed a commit to mprobst/TypeScript that referenced this pull request Jan 10, 2022
fix return type of Intl.DisplayNames.prototype.of
was typed to return always string but can actually return undefined too
see spec https://tc39.es/ecma402/#sec-Intl.DisplayNames.prototype.of
@tao-cumplido tao-cumplido deleted the lib-es2020-intl-displaynames-of branch January 11, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intl.DisplayNames.prototype.of should return string | undefined
3 participants