-
Notifications
You must be signed in to change notification settings - Fork 13.2k
🤖 Sync option descriptions <- website #46465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e4ad36 to
45137e4
Compare
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
you might have changed the line endings on the JSON file - the diff is basically the file |
45137e4 to
3a921d7
Compare
|
Thanks! I've now added |
f3ba7a7 to
5c12658
Compare
c9a620e to
9dd95d3
Compare
fd400dd to
1d05a00
Compare
| type: "boolean", | ||
| category: Diagnostics.Projects, | ||
| description: Diagnostics.Enable_incremental_compilation, | ||
| description: Diagnostics.Save_tsbuildinfo_files_to_allow_for_incremental_compilation_of_projects, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new description was added -> diagnosticMessages.json in https://github.com/microsoft/TypeScript/pull/44409/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5336
| affectsSemanticDiagnostics: true, | ||
| strictFlag: true, | ||
| category: Diagnostics.Type_Checking, | ||
| description: Diagnostics.Type_catch_clause_variables_as_unknown_instead_of_any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| strictFlag: true, | ||
| category: Diagnostics.Type_Checking, | ||
| description: Diagnostics.Type_catch_clause_variables_as_unknown_instead_of_any, | ||
| description: Diagnostics.Default_catch_clause_variables_as_unknown_instead_of_any, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| affectsSemanticDiagnostics: true, | ||
| category: Diagnostics.Type_Checking, | ||
| description: Diagnostics.Enable_error_reporting_when_a_local_variables_aren_t_read, | ||
| description: Diagnostics.Enable_error_reporting_when_local_variables_aren_t_read, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| affectsSemanticDiagnostics: true, | ||
| category: Diagnostics.Type_Checking, | ||
| description: Diagnostics.Include_undefined_in_index_signature_results, | ||
| description: Diagnostics.Add_undefined_to_a_type_when_accessed_using_an_index, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new description was added -> diagnosticMessages.json in https://github.com/microsoft/TypeScript/pull/44409/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5464
| type: "object" | ||
| }, | ||
| description: Diagnostics.List_of_language_service_plugins, | ||
| description: Diagnostics.Specify_a_list_of_language_service_plugins_to_include, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new description was added -> diagnosticMessages.json in https://github.com/microsoft/TypeScript/pull/44409/files#diff-fdf3f532dc2d3188ad1c05c8c9e064d0aa4143b8ba09b8f3313a0243f0a43effR5492
a08f40c to
5be2def
Compare
8073d7e to
4e0dc98
Compare
66bad71 to
4b7a341
Compare
| @@ -1,94 +0,0 @@ | |||
| tests/cases/conformance/classes/classStaticBlock/classStaticBlock22.ts(4,9): error TS1359: Identifier expected. 'await' is a reserved word that cannot be used here. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have this and a bunch of other files been deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabritto Hi! They're baselines for tests that no longer exist --- they're removed by the Accept Baselines and Fix Lints workflow:
git rm -r --quiet tests/baselines/reference :^tests/baselines/reference/docker :^tests/baselines/reference/user - Remove vestigial baselines #45916
| "category": "Error", | ||
| "code": 1271 | ||
| }, | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whitespace here is a little useful for pointing out the gap between 1271 and 1300. I'd prefer to keep it and the others that are like it.
gabritto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment about empty lines, but other than that I think we're good to go
| "category": "Error", | ||
| "code": 1271 | ||
| }, | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as Nathan commented, please leave the blank lines as-is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- @gabritto Thanks! I've restored the blank lines.
aaeb257 to
ba9ba2b
Compare
Get command-line option descriptions from the website Markdown and update their corresponding descriptions in the compiler.
/cc @orta