Skip to content

Conversation

@jablko
Copy link
Contributor

@jablko jablko commented Sep 16, 2021

These baselines are leftovers and can be removed?

  • gulp runtests doesn't recreate them.
  • The tests all pass without them.

What I did was:

  • Add git rm -r --quiet tests/baselines/reference :^tests/baselines/reference/docker :^tests/baselines/reference/user -> .github/workflows/accept-baselines-fix-lints.yaml
  • Run that workflow to remove any unused baselines.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Sep 16, 2021
@typescript-bot
Copy link
Collaborator

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I knew there must be a good number of these. Your git skills are better than mine 😁

@jablko
Copy link
Contributor Author

jablko commented Sep 16, 2021

Thanks!

@andrewbranch andrewbranch merged commit 6aaefe4 into microsoft:main Sep 16, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants