-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain reexports in js emit even when they export nothing #37124
Conversation
cc @rbuckton (since you're the last one to interact with this ellision code) and @andrewbranch (since this is tangentially related to your |
This is a breaking change, right? This feels exactly the same as |
Sortof - in this case, I found our behavior super surprising for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, but it should probably still be noted as a potentially breaking change, albeit with quite small chances of actually breaking anything.
@typescript-bot test this |
Heya @weswigham, I've started to run the parallelized community code test suite on this PR at 372d6e8. You can monitor the build here. |
Heya @weswigham, I've started to run the extended test suite on this PR at 372d6e8. You can monitor the build here. |
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
Hello, just so you are aware, this change did break our project. Please consider releasing TypeScript in alignment with semantic versioning in the future. Thanks and take care 💚 |
would that be possible to have a flag turn off the always reexport even there is nothing? Some times they are .d.ts files and the bundler do not bundle them for browser side code. This would prevent us from upgrading to 3.9 or later versions |
This also broke for our project. In our case we |
There's no error for that because a module |
This also broke our projects due to The compilation behaviour now seems inconsistent given that we can still re-export named types from a FWIW we have been using We've had to roll back to |
Fixes #37123