Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master: Pin TypeScript dependency #816

Merged
merged 1 commit into from
May 18, 2020
Merged

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented May 14, 2020

TypeScript does not follow Semantic Versioning.

This means that the caret (^) syntax used by npm installed a breaking version, as it expects minor and patch releases to be backwards compatible.

This unfortunately means we need to pin the dependency to ensure our code does not break.

export * is Always Retained
In previous TypeScript versions, declarations like export * from "foo" would be dropped in our JavaScript output if foo didn’t export any values. This sort of emit is problematic because it’s type-directed and can’t be emulated by Babel. TypeScript 3.9 will always emit these export * declarations. In practice, we don’t expect this to break much existing code, but bundlers may have a harder time tree-shaking the code.

https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/#breaking-changes

@NickColley NickColley force-pushed the fix-master-failing branch 4 times, most recently from ded1fd7 to bb9d9a1 Compare May 15, 2020 12:14
TypeScript does not follow Semantic Versioning.

This means that the caret (^) syntax used by npm installed a breaking version, as it expects minor and patch releases to be backwards compatible.

This unfortunately means we need to pin the dependency to ensure our code does not break.

https://devblogs.microsoft.com/typescript/announcing-typescript-3-9/#breaking-changes
@NickColley NickColley changed the title Fixing master spike: Pin dependencies Fix master: Pin TypeScript dependency May 15, 2020
@NickColley NickColley marked this pull request as ready for review May 15, 2020 16:33
@NickColley NickColley requested a review from a team as a code owner May 15, 2020 16:33
@NickColley NickColley merged commit a12028f into master May 18, 2020
@NickColley NickColley deleted the fix-master-failing branch May 18, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants