Contextually type parameters in super calls using type arguments on the base class. #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| constructor() { | ||
|
|
||
| super("hi"); // Should error, base constructor has type T for first arg, which is fixed as number in the extends clause |
There was a problem hiding this comment.
Technically, the word you want is "instantiated" rather than "fixed"
There was a problem hiding this comment.
I didn't write it, but I'll consider fixing it.
|
👍 |
| // Instead, they must be fetched from the class declaration's base type node. | ||
| function getEffectiveTypeArguments(callExpression: CallExpression): TypeNode[] { | ||
| if (callExpression.expression.kind === SyntaxKind.SuperKeyword) { | ||
| // TODO (drosen): 1) Discuss if checking needs to be done at this point. |
|
lgtm |
DanielRosenwasser
added a commit
that referenced
this pull request
Jan 28, 2015
Contextually type parameters in super calls using type arguments on the base class.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we might not even have been performing overload resolution correctly here.
Fixes #1480.