Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overload resolution fails to use type arguments from base type in 'super' constructor calls #1480

Closed
zpdDG4gta8XKpMCd opened this issue Dec 14, 2014 · 5 comments · Fixed by #1816
Closed

Overload resolution fails to use type arguments from base type in 'super' constructor calls #1480

zpdDG4gta8XKpMCd opened this issue Dec 14, 2014 · 5 comments · Fixed by #1816
Assignees
@DanielRosenwasser
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 1.5

Comments

@zpdDG4gta8XKpMCd
Copy link

http://www.typescriptlang.org/Playground#src=class%20A%3Cx%2C%20y%3E%20%7B%0D%0A%09constructor(private%20map%3A%20(value%3A%20x)%20%3D%3E%20y)%20%7B%0D%0A%09%09%0D%0A%09%7D%0D%0A%7D%0D%0A%0D%0Aclass%20B%20extends%20A%3Cnumber%2C%20string%3E%20%7B%0D%0A%09%0D%0A%09constructor()%20%7B%20super(value%20%3D%3E%20String(value))%3B%20%7D%0D%0A%7D

image
@DanielRosenwasser DanielRosenwasser changed the title Inference doesn't work on a call to a constructor of a super class. Contextual typing doesn't work on the call to a constructor of a super class. Dec 14, 2014
@DanielRosenwasser DanielRosenwasser added the Bug A bug in TypeScript label Dec 14, 2014
@DanielRosenwasser
Copy link
Member

Will need to check if this reproduces in 1.4.

@RyanCavanaugh
Copy link
Member

Confirmed in latest (fbfb94f)

@mhegazy mhegazy added this to the TypeScript 1.6 milestone Dec 15, 2014
@DanielRosenwasser
Copy link
Member

Basically what seems to be happening is that we fail to fetch type arguments in the call from the base type. I think #360 would have hinted at the problem early on.

@DanielRosenwasser DanielRosenwasser changed the title Contextual typing doesn't work on the call to a constructor of a super class. Overload resolution fails to use type arguments from derived type for super calls Dec 22, 2014
@DanielRosenwasser DanielRosenwasser changed the title Overload resolution fails to use type arguments from derived type for super calls Overload resolution fails to use type arguments from derived type in 'super' constructor calls Dec 23, 2014
@DanielRosenwasser DanielRosenwasser changed the title Overload resolution fails to use type arguments from derived type in 'super' constructor calls Overload resolution fails to use type arguments from base type in 'super' constructor calls Dec 23, 2014
@DanielRosenwasser
Copy link
Member

I'm going to try to stop renaming issues 😅

This was referenced Jan 21, 2015
Closed
Merged
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Jan 28, 2015
@DanielRosenwasser
Copy link
Member

Should be fixed in master.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DanielRosenwasser DanielRosenwasser

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 1.5
4 participants
@zpdDG4gta8XKpMCd @DanielRosenwasser @RyanCavanaugh @mhegazy