Skip to content

Fixes localStorage reference causing error #2796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 6 commits into from
Jul 25, 2023
Merged

Fixes localStorage reference causing error #2796

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e60342c
Fix localStorage reference which should be storeLike
ashubham Apr 20, 2023
8941086
Update package.json
ashubham Apr 20, 2023
5e23207
Merge branch 'v2' into pr/2796
jakebailey May 19, 2023
1f86e1a
Fix lock
jakebailey May 19, 2023
7409609
Merge branch 'v2' into pr-2796
jakebailey Jul 25, 2023
8620f2b
Undo package.json changes, will push in a different PR
jakebailey Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sandbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
},
"dependencies": {
"@typescript/ata": "0.9.3",
"@typescript/vfs": "1.4.0"
"@typescript/vfs": "1.4.1"
},
"devDependencies": {
"@rollup/plugin-commonjs": "^13.0.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/ts-twoslasher/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@
"typescript": false
},
"dependencies": {
"@typescript/vfs": "1.4.0",
"@typescript/vfs": "1.4.1",
"debug": "^4.1.1",
"lz-string": "^1.4.4"
}
}
}
2 changes: 1 addition & 1 deletion packages/typescript-vfs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@typescript/vfs",
"version": "1.4.0",
"version": "1.4.1",
"license": "MIT",
"author": "TypeScript team",
"homepage": "https://github.com/microsoft/TypeScript-Website",
Expand Down
2 changes: 1 addition & 1 deletion packages/typescript-vfs/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export const createDefaultMapFromCDN = (
function cached() {
const storelike = storer || localStorage

const keys = Object.keys(localStorage)
const keys = Object.keys(storelike)
keys.forEach(key => {
// Remove anything which isn't from this version
if (key.startsWith("ts-lib-") && !key.startsWith("ts-lib-" + version)) {
Expand Down
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6076,7 +6076,7 @@ __metadata:
"@rollup/plugin-commonjs": ^13.0.1
"@types/jest": ^25.1.3
"@typescript/ata": 0.9.3
"@typescript/vfs": 1.4.0
"@typescript/vfs": 1.4.1
jest: ^29.5.0
monaco-editor: ^0.32.1
monaco-typescript: ^3.7.0
Expand All @@ -6093,7 +6093,7 @@ __metadata:
"@types/jest": ^25.1.3
"@types/lz-string": ^1.3.33
"@types/prettier": ^1.19.0
"@typescript/vfs": 1.4.0
"@typescript/vfs": 1.4.1
debug: ^4.1.1
husky: ^4.2.3
jest: ^29.5.0
Expand All @@ -6119,7 +6119,7 @@ __metadata:
languageName: node
linkType: hard

"@typescript/vfs@1.4.0, @typescript/vfs@workspace:packages/typescript-vfs":
"@typescript/vfs@1.4.1, @typescript/vfs@workspace:packages/typescript-vfs":
version: 0.0.0-use.local
resolution: "@typescript/vfs@workspace:packages/typescript-vfs"
dependencies:
Expand Down