Fixes localStorage reference causing error #2796
Conversation
|
@microsoft-github-policy-service agree |
|
Please review @orta |
orta
left a comment
orta
left a comment
There was a problem hiding this comment.
Yeah, looks good to me - thanks, you'll need to wait until someone with write access merges it though ( I'd recommend using patch-package till then)
|
This LGTM but I'm not sure what's going on with CI. I'll try a close/reopen. |
|
Hm, maybe it's that version bump that is failing. |
|
Fixed the lock, but, I'm unsure if we need to also start bumping reverse deps to stop multiple versions from getting pulled in due to the use of exact versions. Not sure if there's something about version bumping I'm missing in this repo. |
jakebailey
left a comment
jakebailey
left a comment
There was a problem hiding this comment.
LGTM but will merge/release this with the other PRs that require package publishes.
|
There's a script which will sync verify the internal references are consistent ( and update them to be afterwards) |
|
With bump versions with #2904 to minimize the waiting within the current infrastructure. |
3 participants
Fixes #2762