-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Make sure expected __isa_enabled bit was set before disabling it in feature-dependent tests
#5874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
StephanTLavavej
merged 11 commits into
microsoft:main
from
AlexGuteniev:non-potato-computer
Nov 19, 2025
+46
−39
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d535ed2
centralize `disable_instructions`
AlexGuteniev d6645b9
checked disable
AlexGuteniev 192dfb1
format
AlexGuteniev 04418a1
disarm
AlexGuteniev be5fc01
Add parens, update endif comments.
StephanTLavavej d42301b
Restore the ISA.
StephanTLavavej 1501113
Call getenv_s(), extract lambda.
StephanTLavavej 7aaedf6
"host" => "machine" to avoid confusion.
StephanTLavavej 03795e4
Slightly improve message.
StephanTLavavej 546f176
Assert that we have the feature, instead of aborting.
StephanTLavavej 626f469
Extract run_tests_with_different_isa_levels().
StephanTLavavej File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.